Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dex: Restart on referenced file changes #343738

Merged
merged 1 commit into from
Dec 29, 2024
Merged

nixos/dex: Restart on referenced file changes #343738

merged 1 commit into from
Dec 29, 2024

Conversation

srounce
Copy link
Contributor

@srounce srounce commented Sep 22, 2024 •
edited
Loading

Dex now restarts when EnvironmentFile or client secretFile paths change.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 22, 2024
@srounce srounce force-pushed the dex-restart-on-file-change branch from 5dd6cb3 to 4f0e633 Compare September 22, 2024 15:09
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Sep 22, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 22, 2024
@srounce srounce force-pushed the dex-restart-on-file-change branch from 4f0e633 to 35655b5 Compare September 22, 2024 17:20
FliegendeWurst
FliegendeWurst approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@srounce srounce force-pushed the dex-restart-on-file-change branch from 35655b5 to 4f2ae62 Compare December 28, 2024 11:52
@srounce
nixos/dex: Restart on referenced file changes
b256398 
Dex now restarts when EnvironmentFile or client secretFile paths
change.
@srounce srounce force-pushed the dex-restart-on-file-change branch from 4f2ae62 to b256398 Compare December 28, 2024 11:59
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 28, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 29, 2024
@FliegendeWurst FliegendeWurst merged commit 4b7712c into NixOS:master Dec 29, 2024
38 checks passed
@srounce srounce deleted the dex-restart-on-file-change branch December 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srounce @FliegendeWurst @wegank